Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Add warning for misconfigured HTTP API flags #11360

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore(cli): Add warning for misconfigured HTTP API flags #11360

merged 2 commits into from
Oct 1, 2024

Conversation

TheDhejavu
Copy link
Contributor

Fixes: #11357

Rjected
Rjected requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! Just one suggestion on the log, otherwise this looks good!

crates/rpc/rpc-builder/src/config.rs Outdated Show resolved Hide resolved
@Rjected Rjected changed the title (chore): Add warning for misconfigured HTTP API flags chore(cli): Add warning for misconfigured HTTP API flags Oct 1, 2024
@TheDhejavu @Rjected
Update crates/rpc/rpc-builder/src/config.rs
2dca83a 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Rjected
Rjected approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Rjected Rjected enabled auto-merge October 1, 2024 03:25
@Rjected Rjected added this pull request to the merge queue Oct 1, 2024
Merged via the queue into paradigmxyz:main with commit 6bbb07b Oct 1, 2024
35 checks passed
@TheDhejavu TheDhejavu deleted the rpc-http-config-warning branch October 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit warning log if http APIs are specified on CLI, but --http is not passed
2 participants
@TheDhejavu @Rjected