chore: clear reth rpc types from reth binary #11120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
commented
Sep 23, 2024
bin/reth/src/lib.rs
Outdated
Comment on lines
156
to
157
| /// Alias for a peer identifier | ||
| pub type PeerId = reth_primitives::B512; |
There was a problem hiding this comment.
not sure about this, let me know if you want it somewhere else
There was a problem hiding this comment.
this is already duplicated as a type in a lot of places, so it's available in a re-export already, not sure we need to duplicate it here
see e.g. https://github.com/search?q=repo%3Aparadigmxyz%2Freth%20peerid&type=code
There was a problem hiding this comment.
true, just removed it
onbjerg
approved these changes
Sep 23, 2024
mattsse
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
reth-rpc-typesfromrethbinary.Linked to #11067.