Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only decode fields #11031

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: only decode fields #11031

merged 1 commit into from
Sep 19, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 19, 2024 •
edited
Loading

introduced here: d4cfb95 #10624

we already decode the header and only need to decode the fields here

cc @tcoratger

@mattsse mattsse requested a review from Rjected as a code owner September 19, 2024 10:59
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Sep 19, 2024
@mattsse mattsse requested a review from klkvr September 19, 2024 10:59
@mattsse mattsse enabled auto-merge September 19, 2024 11:04
@mattsse mattsse mentioned this pull request Sep 19, 2024
Closed
@mattsse mattsse added this pull request to the merge queue Sep 19, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Sep 19, 2024
@mattsse mattsse merged commit 03e89b1 into main Sep 19, 2024
36 checks passed
@mattsse mattsse deleted the matt/fix-sidecar-rlp-decoding branch September 19, 2024 11:39
@fgimenez fgimenez mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk