-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: replace reth-primitive imports with alloy-eips #11027
Conversation
f53db6b
to
dcc8c37
Compare
Removing this unused import leads to this
|
@@ -108,7 +108,7 @@ impl TestDownload { | |||
let request = HeadersRequest { | |||
limit: self.limit, | |||
direction: HeadersDirection::Rising, | |||
start: reth_primitives::BlockHashOrNumber::Number(0), // ignored | |||
start: alloy_eips::BlockHashOrNumber::Number(0), // ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can probably use 0u64.into() here
you need to demote it to a dev dependency instead, it's used in a test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
Progress on #10749