Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add display to FromEngine and other messages #10986

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 18, 2024

better observability, keeps debug log but use new display impl

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Sep 18, 2024
@mattsse mattsse force-pushed the matt/add-display-for-from-engine branch from 5536516 to 27e1662 Compare September 18, 2024 12:56
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

@mattsse mattsse enabled auto-merge September 18, 2024 13:00
@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 94c15c0 Sep 18, 2024
35 checks passed
@mattsse mattsse deleted the matt/add-display-for-from-engine branch September 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants