Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): state retrieval for parallel root with persisted parent #10966

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Sep 17, 2024

Description

Fix state retrieval for parallel root of block which attaches to persisted parent.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine labels Sep 17, 2024
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/fix-state-retrieval-for-parallel-root branch from 1afb27e to 62bc10c Compare September 17, 2024 16:05
@rkrasiuk rkrasiuk enabled auto-merge September 17, 2024 16:40
@fgimenez
Copy link
Member

looks good, but locally it causes new hive tests to fail randomly, running on CI to confirm https://github.com/paradigmxyz/reth/actions/runs/10920277624

@fgimenez
Copy link
Member

looks good, but locally it causes new hive tests to fail randomly, running on CI to confirm https://github.com/paradigmxyz/reth/actions/runs/10920277624

yep, some of the current failures persist and there are new ones, especially all the Invalid NewPayload

Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive errors are present on main too, lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit c92b373 Sep 19, 2024
58 of 60 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-state-retrieval-for-parallel-root branch September 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants