fix: always acquire numbers lock first #10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
approved these changes
Sep 11, 2024
rkrasiuk
approved these changes
Sep 11, 2024
crates/chain-state/src/in_memory.rs
Outdated
Comment on lines
151
to
155
| // acquire locks, starting with the numbers lock | ||
| let mut numbers = self.in_memory_state.numbers.write(); | ||
| let mut blocks = self.in_memory_state.blocks.write(); | ||
| blocks.clear(); | ||
| numbers.clear(); |
There was a problem hiding this comment.
call clear directly w/o assigning guard to the variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly the root cause of #10649
lookups by number need to acquire two read locks:
reth/crates/chain-state/src/in_memory.rs
Lines 116 to 119 in 178f850
if writes locks aren't acquired in the same order, we can end up with a deadlock.
this adds some notes on locking, and makes locking order consistent.
we could also remove drop the numbers readlock for these functions before acquiring the blocks readlock, doesn't have an impact really because a miss on hash would result in the provider falling back to disk and by then the block must exist on disk