Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lower persistence threshold #10833

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: lower persistence threshold #10833

merged 1 commit into from
Sep 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 11, 2024

we should be able to lower this now because we can now handle on disk reorgs

@mattsse mattsse added the A-consensus Related to the consensus engine label Sep 11, 2024
fgimenez
fgimenez approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit a5be445 Sep 11, 2024
35 checks passed
@mattsse mattsse deleted the matt/lower-persistence-threshold2 branch September 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @fgimenez