Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent panic during enr conversion #10824

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 11, 2024

this can panic if the enr doesn't include the required fields, such as ip

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Sep 11, 2024
@onbjerg onbjerg enabled auto-merge September 11, 2024 07:07
@mattsse mattsse disabled auto-merge September 11, 2024 07:58
@mattsse mattsse merged commit b3f87ec into main Sep 11, 2024
32 of 34 checks passed
@mattsse mattsse deleted the matt/fix-panic-in-discv5-local-node-record branch September 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants