rpc: replace reth-primitive imports #10812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
previously requested changes
Sep 10, 2024
| use jsonrpsee::{core::RpcResult, proc_macros::rpc}; | ||
| use reth_engine_primitives::EngineTypes; | ||
| use reth_primitives::{Address, BlockHash, BlockId, BlockNumberOrTag, Bytes, B256, U256, U64}; | ||
| use reth_primitives::{BlockId, BlockNumberOrTag}; |
There was a problem hiding this comment.
This could be an alloy_eips import
There was a problem hiding this comment.
yeah, but we can do this separately
mattsse
approved these changes
Sep 11, 2024
| use jsonrpsee::{core::RpcResult, proc_macros::rpc}; | ||
| use reth_engine_primitives::EngineTypes; | ||
| use reth_primitives::{Address, BlockHash, BlockId, BlockNumberOrTag, Bytes, B256, U256, U64}; | ||
| use reth_primitives::{BlockId, BlockNumberOrTag}; |
There was a problem hiding this comment.
yeah, but we can do this separately
unblocking, because this changes a lot of files and smol followup makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #10749
Changed all where direct drop-in-replacement was possible