Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reth-primitives): clean unused file #10765

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 7, 2024

No description provided.

@nkysg nkysg requested a review from Rjected as a code owner September 7, 2024 07:15

#[test]
fn recover_signer_eip1559() {
use crate::hex_literal::hex;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is in alloy-primitives


#[test]
fn recover_signer_legacy() {
use crate::hex_literal::hex;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable now that all of these are just re-exports

@mattsse mattsse added this pull request to the merge queue Sep 7, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 7, 2024
Merged via the queue into paradigmxyz:main with commit b554ecc Sep 7, 2024
35 checks passed
@nkysg nkysg deleted the clean_reth_primitives branch September 7, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants