execution: add transaction and header AT to ConfigureEvmEnv
#10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigureEvmEnvConfigureEvmEnv
tcoratger
commented
Sep 6, 2024
crates/evm/src/lib.rs
Outdated
Comment on lines
123
to
124
| /// Fill transaction environment from a [`TransactionSignedEcRecovered`]. | ||
| fn fill_tx_env(&self, tx_env: &mut TxEnv, transaction: &TransactionSignedEcRecovered); |
There was a problem hiding this comment.
I made this change to simplify and have a single transaction type as associated type instead of two different ATs.
mattsse
requested changes
Sep 9, 2024
1d040ee to
515c02c
Compare
mattsse
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small step toward #10746