Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tree): propagate on_new_persisted_block error #10733

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 5, 2024

This allows us to propagate any error that occurs during on_new_persisted_block, creating a new error type AdvancePersistenceError in the process.

@Rjected Rjected added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Sep 5, 2024
@Rjected Rjected force-pushed the dan/propagate-on-new-persisted-block-error branch from 708fb23 to 657dbc2 Compare September 6, 2024 17:03
@Rjected Rjected enabled auto-merge September 6, 2024 17:04
@Rjected Rjected added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit ed778e1 Sep 6, 2024
34 checks passed
@Rjected Rjected deleted the dan/propagate-on-new-persisted-block-error branch September 6, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants