fix: drop mmap handles before modifying during handle_consistency
#10708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Sep 5, 2024
shekhirin
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #10689
Seems that windows locks files against writing when using mmap. When trying to heal from a sudden crash, we leave the mmap handles open as we prune the offset/data file, which probably causes the
The requested operation cannot be performed on a file with a user-mapped section open. (os error 1224)While this most likely closes the above issue, it has more serious implications. eg. What happens when a rpc starts reading data (using mmap), and at the same time the node is appending a new block? Probably crashes