ethereum-forks: add unit tests for ForkCondition
#10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
commented
Sep 4, 2024
Rjected
requested changes
Sep 5, 2024
There was a problem hiding this comment.
The new tests are good, but it does seem like we need to clarify how fork_block on TTD works.
fork_block only exists for sepolia and holesky, where the fork_block is higher than the actual merge block. For example on sepolia the fork_block is 1735371, but the TTD was reached earlier.
Essentially, when active_at_head is called, if either the TTD is higher or fork block are active, it should return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part has some logic elements so I think it doesn't hurt to add some simple tests to cover all that.