-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op): parse l1 block info from l2 tx input #10664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the offsets were wrong because of the selector is already removed here?
but doesn't this ignore the block sequencer number as described in the function docs
@clabby mind taking a look at this?
ah maybe the function docs are wrong because the order is |
no they were wrong despite that, base fee scalar was before taken at offset 12..16, when actually it's at offset 0..4. the selector is only 4 bytes. got the correct order from op-geth code, as linked in the code comment https://github.com/ethereum-optimism/op-geth/blob/60038121c7571a59875ff9ed7679c48c9f73405d/core/types/rollup_cost.go#L317-L328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me given the above comments are addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - looks like the old test for Ecotone also needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the function docs need to be updated
L111 is incorrect and should be removed
Closes #10462
Fixes offsets for parsing l1 base fee scalar and l1 blob base fee scalar