Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: expose TransactionFetcher param in cli #10635

Merged
merged 16 commits into from
Aug 31, 2024
Merged

chore: expose TransactionFetcher param in cli #10635

merged 16 commits into from
Aug 31, 2024

Conversation

royvardhan
Copy link
Contributor

@royvardhan royvardhan commented Aug 30, 2024 •
edited by emhane
Loading

Exposes TransactionFetcher params in cli: DEFAULT_MAX_CAPACITY_CACHE_PENDING_FETCH
Closes #10326

@royvardhan royvardhan changed the title 10326 chore: expose max_capacity_cache_pending_fetch Aug 30, 2024
@royvardhan royvardhan marked this pull request as ready for review August 30, 2024 18:38
@royvardhan royvardhan changed the title chore: expose max_capacity_cache_pending_fetch chore: expose TransactionFetcher param max_capacity_cache_pending_fetch in cli Aug 30, 2024
@royvardhan royvardhan changed the title chore: expose TransactionFetcher param max_capacity_cache_pending_fetch in cli chore: expose TransactionFetcher param in cli Aug 30, 2024
@royvardhan
Copy link
Contributor Author

@emhane Not being able to comprehend the book ci

emhane
emhane requested changes Aug 30, 2024
View reviewed changes
crates/net/network/src/transactions/config.rs Outdated Show resolved Hide resolved
crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
@emhane emhane mentioned this pull request Aug 30, 2024
Closed
8 tasks
@royvardhan royvardhan requested a review from emhane August 31, 2024 18:04
emhane
emhane approved these changes Aug 31, 2024
View reviewed changes
crates/net/network/src/transactions/config.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions/fetcher.rs Outdated Show resolved Hide resolved
@emhane emhane added this pull request to the merge queue Aug 31, 2024
Merged via the queue into paradigmxyz:main with commit 7269cf2 Aug 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose TransactionFetcher params in cli
2 participants
@royvardhan @emhane