Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): dedup rpc getTxBySenderAndNonce #10600

Merged
merged 9 commits into from
Aug 31, 2024
Merged

feat(rpc): dedup rpc getTxBySenderAndNonce #10600

merged 9 commits into from
Aug 31, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 28, 2024

closes #10544

@jsvisa jsvisa changed the title Dedup get tx by sender and nonce feat(rpc): dedup rpc getTxBySenderAndNonce Aug 28, 2024
emhane
emhane requested changes Aug 30, 2024
View reviewed changes
crates/rpc/rpc-eth-api/src/helpers/transaction.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/transaction.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/transaction.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/transaction.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/otterscan.rs Outdated Show resolved Hide resolved
jsvisa added 8 commits August 31, 2024 11:27
@jsvisa
feat(rpc/rpc-eth-api): move get_tx_by_sender_and_nonce from core to t…
8a95f18 
…ransaction

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
feat(rpc/otterscan): implement ApiServer
fba43ed 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
typo
4c592d0 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
cargo check
77ec957 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
apply review
f3103a3 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
set as trait method instead of pub func
54f94ac 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
use self.xxx
052b549 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
more fp
c2e8067 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa force-pushed the dedup-getTxBySenderAndNonce branch from fe3921f to c2e8067 Compare August 31, 2024 04:23
@jsvisa
block_receipts
a6480d6 
Signed-off-by: jsvisa <delweng@gmail.com>
emhane
emhane approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spot on

crates/rpc/rpc-eth-api/src/helpers/transaction.rs Show resolved Hide resolved
@emhane emhane added this pull request to the merge queue Aug 31, 2024
@emhane emhane mentioned this pull request Aug 31, 2024
Closed
Merged via the queue into paradigmxyz:main with commit 3efe22e Aug 31, 2024
34 checks passed
@jsvisa jsvisa deleted the dedup-getTxBySenderAndNonce branch August 31, 2024 17:45
@emhane emhane mentioned this pull request Sep 4, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify gettransactionbySenderAndNonce
2 participants
@jsvisa @emhane