Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Extend BuiltPayload type #10583

Merged
merged 9 commits into from
Aug 31, 2024
Merged

Feat: Extend BuiltPayload type #10583

merged 9 commits into from
Aug 31, 2024

Conversation

malik672
Copy link
Contributor

closes #10436

@emhane emhane added S-blocked This cannot more forward until something else changes S-needs-design This issue requires design work to think about how it would best be accomplished labels Aug 28, 2024
@emhane
Copy link
Member

emhane commented Aug 28, 2024

what unblocks this issue @mattsse ?

onbjerg
onbjerg requested changes Aug 28, 2024
View reviewed changes
crates/ethereum/engine-primitives/src/payload.rs Outdated Show resolved Hide resolved
crates/ethereum/engine-primitives/src/payload.rs Outdated Show resolved Hide resolved
crates/payload/primitives/src/traits.rs Outdated Show resolved Hide resolved
crates/payload/builder/src/test_utils.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/payload.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/payload.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
crates/ethereum/payload/src/lib.rs Outdated Show resolved Hide resolved
malik672 and others added 3 commits August 28, 2024 20:47
@malik672 @onbjerg
Update crates/ethereum/engine-primitives/src/payload.rs
7b70d73 
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
@malik672
changes
5325614
@malik672
changes
bfe05b2
onbjerg
onbjerg requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there!

crates/ethereum/payload/src/lib.rs Outdated Show resolved Hide resolved
crates/ethereum/payload/src/lib.rs Outdated Show resolved Hide resolved
crates/ethereum/payload/src/lib.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
crates/payload/builder/src/test_utils.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg added C-enhancement New feature or request and removed S-blocked This cannot more forward until something else changes S-needs-design This issue requires design work to think about how it would best be accomplished labels Aug 29, 2024
@malik672 malik672 requested a review from onbjerg August 29, 2024 11:20
onbjerg
onbjerg approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane added this pull request to the merge queue Aug 31, 2024
Merged via the queue into paradigmxyz:main with commit 17f6225 Aug 31, 2024
34 checks passed
@mattsse mattsse mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend BuiltPayload type
3 participants
@malik672 @emhane @onbjerg