Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(provider): random_block and random_block_range functions #10563

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor(provider): random_block and random_block_range functions #10563

merged 1 commit into from
Aug 27, 2024

Conversation

jenpaff
Copy link
Collaborator

@jenpaff jenpaff commented Aug 27, 2024 •
edited
Loading

Closes #10457

Implementation Details:

  • created new struct BlockParams and BlockRangeParams used to pass arguments for random block generation
  • decided to keep them separate now for simplicity, could be refactored further

@jenpaff jenpaff changed the title Refactor random_block and random_block_range functions Refactor: random_block and random_block_range functions Aug 27, 2024
@jenpaff jenpaff mentioned this pull request Aug 27, 2024
Closed
@jenpaff jenpaff force-pushed the jenpaff/refactor-random_blocks-function-v2 branch from 3f4ba76 to 8e25af9 Compare August 27, 2024 13:58
@shekhirin shekhirin changed the title Refactor: random_block and random_block_range functions refactor(provider): random_block and random_block_range functions Aug 27, 2024
@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 27, 2024
@jenpaff jenpaff marked this pull request as ready for review August 27, 2024 14:11
shekhirin
shekhirin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it looks much better now!

@jenpaff jenpaff added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 7ea748e Aug 27, 2024
34 checks passed
@jenpaff jenpaff deleted the jenpaff/refactor-random_blocks-function-v2 branch August 27, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor random_blocks function
2 participants
@jenpaff @shekhirin