Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make js-feature non default #10445

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Make js-feature non default #10445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
552e186
Make js-feature non default
nkysg Aug 22, 2024
0839283
Update crates/rpc/rpc-eth-types/Cargo.toml
nkysg Aug 22, 2024
c70623d
Make js-feature default
nkysg Aug 22, 2024
9f4ce1e
revert
nkysg Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rpc/rpc-eth-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ serde_json.workspace = true


[features]
default = ["js-tracer"]
default = []
nkysg marked this conversation as resolved.
Show resolved Hide resolved
js-tracer = ["revm-inspectors/js-tracer"]
4 changes: 3 additions & 1 deletion crates/rpc/rpc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ reth-revm.workspace = true
reth-tasks = { workspace = true, features = ["rayon"] }
reth-consensus-common.workspace = true
reth-rpc-types-compat.workspace = true
revm-inspectors = { workspace = true, features = ["js-tracer"] }
revm-inspectors.workspace = true
reth-network-peers = { workspace = true, features = ["secp256k1"] }
reth-evm.workspace = true
reth-rpc-eth-types = { workspace = true, features = ["js-tracer"] }
Expand Down Expand Up @@ -84,6 +84,8 @@ jsonrpsee-types.workspace = true
jsonrpsee = { workspace = true, features = ["client"] }

[features]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make js-tracer default here, for this pr, and solve making it non-default in this crate in a followup pr

js-tracer = ["revm-inspectors/js-tracer"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this likely needs to also be enabled for eth-rpc-types

optimism = [
"reth-primitives/optimism",
"reth-rpc-types-compat/optimism",
Expand Down
Loading