Check features powerset for reth-primitives
#10138
Merged
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another followup of #10130
This PR adds
cargo hackto makefile to validate thatreth-primitivesandreth-primitive-traitscan compile with all feature combinations.thiserror-no-stdin favor of originalthiserrorand feature gate it behind std. Some details I've described in Fix various compilation errors for no-std in crates #9478 (comment) . But this PR does not remove it from whole repo, I leave it up to the reth team.c-kgzdoes not needthiserrordependency.c-kgzconstants are only available withstdreth-codecsfeature only available withstd, because it is quite hard to make compilezstdinno_stdor riscv target.