Remove all externs.

parachain-tracker · Sep 4, 2019 · c3fda35 · c3fda35
1 parent 2b406ba
commit c3fda35
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 51 deletions.
diff --git a/codelab-elements/google-codelab/BUILD.bazel b/codelab-elements/google-codelab/BUILD.bazel
@@ -30,18 +30,6 @@ closure_js_library(
     deps = [
         "@io_bazel_rules_closure//closure/library",
         ":google_codelab_soy",
-        ":externs",
-    ]
-)
-
-# Externs.
-closure_js_library(
-    name = "externs",
-    srcs = [
-        "externs.js",
-    ],
-    suppress = [
-        "JSC_STRICT_INEXISTENT_PROPERTY",
     ]
 )
 

diff --git a/codelab-elements/google-codelab/externs.js b/codelab-elements/google-codelab/externs.js
diff --git a/codelab-elements/google-codelab/google_codelab.js b/codelab-elements/google-codelab/google_codelab.js
@@ -559,6 +559,7 @@ class Codelab extends HTMLElement {
       return;
     }
 
+
     let time = 0;
     for (let i = this.currentSelectedStep_; i < this.steps_.length; i++) {
       const step = /** @type {!Element} */ (this.steps_[i]);
@@ -752,8 +753,9 @@ class Codelab extends HTMLElement {
     if (feedbackLink) {
       this.eventHandler_.listen(feedbackLink, events.EventType.CLICK,
         (e) => {
-          if ('userfeedback' in window && userfeedback.api) {
-            userfeedback.api.startFeedback({productId: '5143948'});
+          if ('userfeedback' in window) {
+            window['userfeedback']['api']['startFeedback']
+                ({productId: '5143948'});
           }
         });
     }