-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add important dates feature #85
Merged
panzarino
merged 21 commits into
panzarino:master
from
trevor-viljoen:feature/important_dates
Apr 9, 2018
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3f81834
Add tests for mlbgame.important_dates
trevor-viljoen f492ae0
Add important dates feature
trevor-viljoen 477ba25
Update tests for important_dates to use year
trevor-viljoen 19458a2
Use year int rather than datetime object
trevor-viljoen 823094a
Change missed datetime object to int year
trevor-viljoen 52c4d71
Add test for ValueError
trevor-viljoen c7a41a1
Fix pep8 errors in data.py
trevor-viljoen 3c02af6
Fix pep8 errors in game.py
trevor-viljoen ebe6ab5
Fix pep8 errors in stats.py
trevor-viljoen 97e2607
Requires dateutil to parse date strings
trevor-viljoen 7336c08
dateutil no longer necessary
trevor-viljoen 924643c
Use datetime.strptime to parse date string
trevor-viljoen a82abbc
Update to correct variable
trevor-viljoen d69d522
Only return date string from dtfmt
trevor-viljoen 59b9318
Add more test coverage for ImportantDates class
trevor-viljoen 8fc560a
Add more test coverage
trevor-viljoen 487da84
Don't calculate year at import time
trevor-viljoen 882cbb6
Clean up extra lines
trevor-viljoen fae6265
Fix import order
trevor-viljoen 9e421d2
Move dtfmt and strformat
trevor-viljoen 5fddb82
Update function names
trevor-viljoen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use year int rather than datetime object
- Loading branch information
commit 19458a2cacc6e77a05419c59b6f2190bb46de83f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using
year=None
here and then assigningyear
todatetime.now().year
in the function body ifNone
is passed in.The way it's currently done the default value for
year
will be calculated at import time.