-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to speed up tests with xdist. #73
Conversation
This does speed up tests on OSX modestly, perhaps 10-15%. On my machine it speeds things up by ~60%. Perhaps more importantly this caught a bug in Pants pre-Pex 2.x:
This should not be a problem in Another - not sure it's worth it change. |
I'll leave the CI shard with the concurrency error red until you review. If you like it, then I can click retry and we'll have known flaky <=1.26.0.dev0 Pants executions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making so many improvements to this repo recently!
Your call on if we're okay with the flakes. I was already planning on no longer testing <= 1.26.0 so that we can guarantee |
@Eric-Arellano it's probably best you try this on OSX 1st. |
Closing this due to #142 - we will get test concurrency via Pants once that is merged. |
No description provided.