Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate to ./pants when [DEFAULT] delegate_bootstrap=true. #75

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

kaos
Copy link
Member

@kaos kaos commented Jan 26, 2023

The choice of config section for the pants.toml config file was made to have something that won't choke the regular Pants configuration verification and also not show up in any online help.

Closes #33

The choice of config section for the `pants.toml` config file was made to have something that won't
choke the regular Pants configuration verification and also not show up in any online help.
@kaos
Copy link
Member Author

kaos commented Jan 26, 2023

I'm not sure how/where to write tests for this, but it seems to do what I want when tested on the Pants repo.

I have observed though that sometimes it seems like it's attempting to connect with what I suspect is debugpy, but I've no clue as to why that would be.

@kaos kaos requested a review from jsirois January 26, 2023 02:45
@jsirois
Copy link
Contributor

jsirois commented Jan 27, 2023

I'm not sure how/where to write tests for this, but it seems to do what I want when tested on the Pants repo.

You just reviewed the ~same testing needs here:
https://github.com/pantsbuild/scie-pants/pull/77/files#diff-7ff30d851f930debdd0596654b3cb5b82ed6bf7b19db396907dd2a7564514ffcR931

That clones the pants repo quickly at a fixed sha and builds pants and caches it all (CI too). With that - a Pants repo - you have what you need to verify scie-pants works when run with that clone as its CWD.

@kaos
Copy link
Member Author

kaos commented Jan 27, 2023

I'm not sure how/where to write tests for this, but it seems to do what I want when tested on the Pants repo.

You just reviewed the ~same testing needs here: https://github.com/pantsbuild/scie-pants/pull/77/files#diff-7ff30d851f930debdd0596654b3cb5b82ed6bf7b19db396907dd2a7564514ffcR931

That clones the pants repo quickly at a fixed sha and builds pants and caches it all (CI too). With that - a Pants repo - you have what you need to verify scie-pants works when run with that clone as its CWD.

Yup, I recognized it when I saw it--thanks for not assuming I did :)

@kaos
Copy link
Member Author

kaos commented Feb 2, 2023

Hmm... locally this works for me 🤔 -- not sure yet what's different here.

@kaos
Copy link
Member Author

kaos commented Feb 2, 2023

Hmm... locally this works for me 🤔 -- not sure yet what's different here.

Ah, it seems that the pants repo is not re-fetched and thus patched. So my new patch is never applied..

Is there any way to clear the caches? (I bumped the cache key in the ci.yaml workflow)

Edit ftr: this has clearly been solved by now.

Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this @kaos

@kaos kaos merged commit 41900c4 into pantsbuild:main Feb 3, 2023
@kaos kaos deleted the delegate-bootstrap branch February 3, 2023 02:29
kaos added a commit to pantsbuild/pants that referenced this pull request Feb 3, 2023
Leverage pantsbuild/scie-pants#75

This allow us to run `pants ...` instead of `./pants ...` to run Pants from sources in the Pants repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special-case the Pants repo.
2 participants