Propagate scie-pants' version into the pants invocation #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cc176b to
6e2daa5
Compare
thejcannon
reviewed
Aug 23, 2023
Comment on lines
+16
to
+17
| NB. this version was published as 0.9.0, but `PANTS_BOOTSTRAP_VERSION=report pants` reports itself | ||
| as 0.9.1. |
There was a problem hiding this comment.
I think there was just a small mistake in setting the version in Cargo.toml in #239. I don't think it causes problems, just thought it'd be sensible to call out why 0.9.1 seems to be missed so people don't get confused.
There was a problem hiding this comment.
I have no clue how I messed that up, lol
thejcannon
approved these changes
Aug 23, 2023
huonw
added a commit
to pantsbuild/pants
that referenced
this pull request
Aug 23, 2023
This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or earlier, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes #19600
huonw
added a commit
to huonw/pants
that referenced
this pull request
Aug 23, 2023
…uild#19654) This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or earlier, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes pantsbuild#19600
thejcannon
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Aug 23, 2023
…-pick of #19654) (#19655) This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or earlier, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes #19600
github-actions bot
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Aug 29, 2023
This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or earlier, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes #19600
huonw
added a commit
to pantsbuild/pants
that referenced
this pull request
Aug 29, 2023
…-pick of #19654) (#19694) This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or later, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes #19600 Co-authored-by: Huon Wilson <huon@exoflare.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
SCIE_PANTS_VERSIONenv var when invoking pants, so that pants can read it and encourage users to upgrade if they need to.For example, 2.17 will be the last release that supports the PyPI-based distribution model and Pants 2.18 will require scie-pants 0.9 or greater. So, in pantsbuild/pants#19600, we're planning to have pants 2.17 encourage users to upgrade
scie-pantsif it's too old.This PR preps for the release too, by bumping the version and adding a changelog entry. As part of this, I noticed the 0.9.0 release was accidentally configured as 0.9.1 in Cargo.toml, so updated the changelog to mention this.