Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename V2 Configuration to FieldSet #9668

Merged
merged 2 commits into from
May 1, 2020

Conversation

Eric-Arellano
Copy link
Contributor

This name describes the ad hoc collection of Fields needed by some rules, such as the Fields needed to create an AWS Lambda.

"Configuration" is a very overloaded term and doesn't express its relationship to the Target API / Fields.

Rejected alternatives:

  • Fields -> no way to make this plural.
  • FieldCollection -> clunkier than FieldSet.
  • AdHocTarget -> clunky and too close to Target.

[ci skip-rust-tests]
[ci skip-jvm-tests]

# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
@Eric-Arellano Eric-Arellano merged commit cec63e0 into pantsbuild:master May 1, 2020
@Eric-Arellano Eric-Arellano deleted the field-set branch May 1, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants