Switch to Py2 and Py3 shards. #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
529a3b9 to
8d7e19e
Compare
e85e41f to
8d7e19e
Compare
eabd8c5 to
e6a2995
Compare
…le from loading on both 2 and 3.
…o bootstrap. Changing interpreter-constraints requires a clean-all... need to file an issue.
cf6ec7a to
8373bce
Compare
wisechengyi
reviewed
Aug 8, 2018
| @@ -191,6 +193,7 @@ def test_transforms_not_discard_page_tocs(self): | |||
| self.assertIn('DEPTH=1 LINK=one TEXT=Section One', rendered) | |||
| self.assertIn('DEPTH=1 LINK=two TEXT=Section Two', rendered) | |||
|
|
|||
| @pytest.mark.skipif(sys.version_info >= (3,0), reason="TODO: See #6062.") | |||
There was a problem hiding this comment.
What is the general philosophy on skipping py3 test given
# Allowed to fail.
- ./build-support/bin/ci.sh -x -3efkmrjcnt "${SHARD}" || exit 0
in .travis.yml?
There was a problem hiding this comment.
To make it past the "internal" tests in order to run the unit tests.
8373bce to
488536f
Compare
|
This is reviewable. The individual commits should be useful to review independently. |
jsirois
approved these changes
Aug 8, 2018
.travis.yml
Outdated
|
|
||
| - <<: *default_test_config | ||
| env: | ||
| - SHARD="Unit tests for pants and pants-plugins - shard 1" | ||
| - SHARD="Py2 - Unit tests in for pants and pants-plugins" |
There was a problem hiding this comment.
'in' or 'for' instead of 'in for'
build-support/bin/ci.sh
Outdated
| @@ -15,6 +15,8 @@ Runs commons tests for local or hosted CI. | |||
|
|
|||
| Usage: $0 (-h|-fxbkmsrjlpuyncia) | |||
| # | ||
| # We additionally remove the ifdefs that apply conditional `init` logic for Py2 vs Py3, in order | ||
| # to define a module that is loadable by either 2 or 3. | ||
| # TODO: Because PyPy uses the same `init` function name regardless of the python version, this |
There was a problem hiding this comment.
To my knowledge we have never supported running on PyPy like pex does. Perhaps kill the TODO.
There was a problem hiding this comment.
At one point about two years ago I ran pants under PyPy, and saw a 30 percent speedup... would be awesome to be able to support it at some point...
CMLivingston
pushed a commit
to CMLivingston/pants
that referenced
this pull request
Aug 27, 2018
### Problem In order to avoid backsliding as changes are made in service of pantsbuild#6062, we should begin running a travis shard that uses python 3 even before it has gone completely green. ### Solution Repurpose one of the unit test shards to run with python 3, with abbreviated logging and `|| exit 0`. This should allow us to track the total failure count under python 3, and attempt to push it down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to avoid backsliding as changes are made in service of #6062, we should begin running a travis shard that uses python 3 even before it has gone completely green.
Solution
Repurpose one of the unit test shards to run with python 3, with abbreviated logging and
|| exit 0. This should allow us to track the total failure count under python 3, and attempt to push it down.