Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A test to prove that @fromfile invalidation works now. #21901

Merged
merged 5 commits into from
Feb 3, 2025
Merged

A test to prove that @fromfile invalidation works now. #21901

merged 5 commits into from
Feb 3, 2025

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Feb 1, 2025

See #10360

@benjyw benjyw added the release-notes:not-required PR doesn't require mention in release notes label Feb 1, 2025
@benjyw benjyw requested review from huonw and tdyas February 1, 2025 04:51
@benjyw benjyw changed the title A test to prove that @fromfile invaldiation works now. A test to prove that @fromfile invalidation works now. Feb 3, 2025
@benjyw benjyw requested a review from tdyas February 3, 2025 01:29
benjyw
benjyw commented Feb 3, 2025
View reviewed changes
src/python/pants/init/options_initializer.py
@@ -135,7 +135,6 @@ class OptionsInitializer:
TODO: We would eventually like to use the bootstrap Scheduler to construct the
OptionsBootstrapper as well, but for now we do the opposite thing, and the Scheduler is
used only to resolve plugins.
see: https://github.com/pantsbuild/pants/issues/10360
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #11568 for context, but what this comment was trying to say was that doing this Scheduler->Bootstrapper thing would allow resolving #10360, which we now see as resolved anyway. So...

@benjyw benjyw merged commit 7821be7 into pantsbuild:main Feb 3, 2025
24 checks passed
@benjyw benjyw deleted the fromfile_invalidation branch February 3, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdyas tdyas tdyas approved these changes

@huonw huonw Awaiting requested review from huonw

Assignees
No one assigned
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjyw @tdyas