Don't include macOS 12 in "_before_ 12" deprecation check #21420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tdyas
approved these changes
Sep 16, 2024
WorkerPants
pushed a commit
that referenced
this pull request
Sep 16, 2024
This was a fence-post error in #21326, where the "before 12" check included 12, instead of just 10.15 and 11. This mistake led to getting deprecation warnings about macOS 10.15 & 11 while running on macOS 12.
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.23.xSuccessfully opened #21421. Thanks again for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fence-post error in #21326, where the "before 12" check included 12, instead of just 10.15 and 11. This mistake led to getting deprecation warnings about macOS 10.15 & 11 while running on macOS 12.