Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote_provider = "..." option, replacing scheme-look-ups #20240

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Add remote_provider = "..." option, replacing scheme-look-ups #20240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c67c0e
Add remote_provider = "..." option, replacing scheme-look-ups
huonw Nov 20, 2023
35cc72c
Add Rust enum
huonw Dec 29, 2023
23fafe0
Propagate enum through Rust
huonw Dec 29, 2023
5c90b46
Use enum when choosing a provider
huonw Dec 29, 2023
5479720
Propagate enum through Python code
huonw Dec 29, 2023
dfc6061
Merge remote-tracking branch 'upstream/main' into huonw/19902-separat…
huonw Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/docs/using-pants/remote-caching-&-execution/remote-caching.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The values of the `ACTIONS_CACHE_URL` and `ACTIONS_RUNTIME_TOKEN` environment va
uses: actions/github-script@v6
with:
script: |
core.exportVariable('PANTS_REMOTE_STORE_ADDRESS', 'experimental:github-actions-cache+' + (process.env.ACTIONS_CACHE_URL || ''));
core.exportVariable('PANTS_REMOTE_STORE_ADDRESS', process.env.ACTIONS_CACHE_URL);
core.exportVariable('PANTS_REMOTE_OAUTH_BEARER_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN);
```

Expand All @@ -65,6 +65,7 @@ Once the GitHub values are configured, Pants will read the environment variables
```toml
[GLOBAL]
# GitHub Actions cache URL and token are set via environment variables
remote_provider = "experimental-github-actions-cache"
remote_cache_read = true
remote_cache_write = true
```
Expand All @@ -85,7 +86,8 @@ To read and write the cache to `/path/to/cache`, you will need to configure `pan

```toml
[GLOBAL]
remote_store_address = "experimental:file:///path/to/cache"
remote_store_provider = "experimental-file"
remote_store_address = "file:///path/to/cache"
remote_cache_read = true
remote_cache_write = true
```
Expand Down
6 changes: 3 additions & 3 deletions src/python/pants/engine/internals/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
LOCAL_STORE_LEASE_TIME_SECS,
ExecutionOptions,
LocalStoreOptions,
normalize_remote_address,
)
from pants.util.contextutil import temporary_file_path
from pants.util.logging import LogLevel
Expand Down Expand Up @@ -179,6 +178,7 @@ def __init__(
parsed_javascript_deps_result=NativeParsedJavascriptDependencies,
)
remoting_options = PyRemotingOptions(
provider=execution_options.remote_provider.value,
execution_enable=execution_options.remote_execution,
store_headers=execution_options.remote_store_headers,
store_chunk_bytes=execution_options.remote_store_chunk_bytes,
Expand All @@ -193,8 +193,8 @@ def __init__(
execution_headers=execution_options.remote_execution_headers,
execution_overall_deadline_secs=execution_options.remote_execution_overall_deadline_secs,
execution_rpc_concurrency=execution_options.remote_execution_rpc_concurrency,
store_address=normalize_remote_address(execution_options.remote_store_address),
execution_address=normalize_remote_address(execution_options.remote_execution_address),
store_address=execution_options.remote_store_address,
execution_address=execution_options.remote_execution_address,
execution_process_cache_namespace=execution_options.process_execution_cache_namespace,
instance_name=execution_options.remote_instance_name,
root_ca_certs_path=execution_options.remote_ca_certs_path,
Expand Down
Loading