Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for removal of python36 from Github Actions hostedtoolcache #19901

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update tests for removal of python36 from Github Actions hostedtoolcache #19901

merged 2 commits into from
Sep 22, 2023

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Sep 21, 2023

Github Actions recently removed python3.6 from /opt/hostedtoolcache, which means that our pantsbuild/actions/expose-pythons action does not expose it.

This causes tests which require Python 3.6 to fail (example) on main (and in branches).

@stuhood stuhood added needs-cherrypick category:internal CI, fixes for not-yet-released features, etc. labels Sep 21, 2023
@stuhood stuhood added this to the 2.16.x milestone Sep 21, 2023
@stuhood stuhood enabled auto-merge (squash) September 21, 2023 23:00
@stuhood stuhood mentioned this pull request Sep 21, 2023
Merged
kaos
kaos approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice with a comment somewhere (next to the resource target in the BUILD file perhaps) mentioning how to generate these platform json files.. ;)

@stuhood stuhood merged commit 1bb84ed into pantsbuild:main Sep 22, 2023
WorkerPants pushed a commit that referenced this pull request Sep 22, 2023
@stuhood @WorkerPants
Update tests for removal of python36 from Github Actions hostedtool…
47d2ed6 
…cache (#19901)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).
WorkerPants pushed a commit that referenced this pull request Sep 22, 2023
@stuhood @WorkerPants
Update tests for removal of python36 from Github Actions hostedtool…
bea0602 
…cache (#19901)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.16.x

I was unable to cherry-pick this PR to 2.16.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.16.x \
  && git checkout -b cherry-pick-19901-to-2.16.x FETCH_HEAD \
  && git cherry-pick 1bb84ed4720525b79fcdf3fd3664b8c087043982
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "19901" "2.16.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

✔️ 2.17.x

Successfully opened #19905.

✔️ 2.18.x

Successfully opened #19904.

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Sep 22, 2023
@stuhood stuhood deleted the stuhood/update-for-removal-of-python36 branch September 22, 2023 03:12
stuhood added a commit to stuhood/pants that referenced this pull request Sep 22, 2023
@stuhood
Update tests for removal of python36 from Github Actions hostedtool…
8e1004a 
…cache (pantsbuild#19901)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).
huonw pushed a commit that referenced this pull request Sep 22, 2023
@WorkerPants @stuhood
Update tests for removal of python36 from Github Actions hostedtool…
8aaac91 
…cache (Cherry-pick of #19901) (#19904)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).

Co-authored-by: Stu Hood <stuhood@gmail.com>
huonw pushed a commit that referenced this pull request Sep 22, 2023
@WorkerPants @stuhood
Update tests for removal of python36 from Github Actions hostedtool…
65c5b49 
…cache (Cherry-pick of #19901) (#19905)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).

Co-authored-by: Stu Hood <stuhood@gmail.com>
huonw pushed a commit that referenced this pull request Sep 22, 2023
@stuhood
Update tests for removal of python36 from Github Actions hostedtool…
df2f1ae 
…cache (Cherry-pick of #19901) (#19909)

Github Actions recently removed `python3.6` from `/opt/hostedtoolcache`,
which means that our [`pantsbuild/actions/expose-pythons`
action](https://github.com/pantsbuild/actions/blob/main/expose-pythons/action.yml)
does not expose it.

This causes tests which require Python 3.6 to fail
([example](https://github.com/pantsbuild/pants/actions/runs/6265433640/job/17021049356?pr=19894))
on `main` (and in branches).
@kaos kaos mentioned this pull request Sep 23, 2023
Merged
This was referenced Oct 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@benjyw benjyw Awaiting requested review from benjyw

@thejcannon thejcannon Awaiting requested review from thejcannon

Assignees
No one assigned
Labels
auto-cherry-picking-failed Auto Cherry-Picking Failed category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
2.16.x
Development

Successfully merging this pull request may close these issues.
5 participants
@stuhood @WorkerPants @kaos @Eric-Arellano @huonw