Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust 1.72.1 #19881

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Upgrade to Rust 1.72.1 #19881

merged 3 commits into from
Sep 21, 2023

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Sep 19, 2023

@huonw huonw added the category:internal CI, fixes for not-yet-released features, etc. label Sep 19, 2023
@huonw
Copy link
Contributor Author

huonw commented Sep 20, 2023

Unscientific benchmark: rm -rf src/rust/engine/target/debug followed by MODE=debug pants version.

Both 1.72.0 and 1.72.1 take about 2:25 on my machine, i.e. pants didn't seem to be affected by the compilation time regression in 1.72.0 that was fixed in 1.72.1. (It seemed to be something in the type checker, so would affect debug builds too, not just release.)

@huonw huonw marked this pull request as ready for review September 20, 2023 04:40
@huonw huonw requested review from tdyas and thejcannon September 20, 2023 04:40
@tdyas tdyas mentioned this pull request Sep 20, 2023
@huonw
Copy link
Contributor Author

huonw commented Sep 20, 2023

(I'm gonna wait until the bigger/more interesting #19868 lands, to reduce the fuss with that PR if there's merge skew between them, somehow.)

@huonw huonw merged commit 324d976 into main Sep 21, 2023
@huonw huonw deleted the huonw/rust-1.72.1 branch September 21, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants