Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try and garbage collect tempfiles #19103

Merged
merged 1 commit into from
May 23, 2023
Merged

Don't try and garbage collect tempfiles #19103

merged 1 commit into from
May 23, 2023

Conversation

thejcannon
Copy link
Member

Fixes #19007 by giving temp files an extension and checking when collecting fingerprints

@thejcannon thejcannon added needs-cherrypick category:bugfix Bug fixes for released features labels May 23, 2023
@thejcannon thejcannon added this to the 2.17.x milestone May 23, 2023
@thejcannon thejcannon requested review from stuhood and huonw May 23, 2023 15:50
stuhood
stuhood approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thejcannon thejcannon enabled auto-merge (squash) May 23, 2023 16:29
@thejcannon thejcannon merged commit 2b09e54 into pantsbuild:main May 23, 2023
@thejcannon thejcannon deleted the dontcleantemp branch May 23, 2023 17:36
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@thejcannon @WorkerPants
Don't try and garbage collect tempfiles (#19103)
9c94a5f 
Fixes #19007 by giving temp files an extension and checking when
collecting fingerprints
stuhood pushed a commit that referenced this pull request May 26, 2023
@WorkerPants @thejcannon
Don't try and garbage collect tempfiles (Cherry-pick of #19103) (#19113)
1abb154 
Fixes #19007 by giving temp files an extension and checking when
collecting fingerprints

Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
@huonw huonw mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@huonw huonw Awaiting requested review from huonw

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.17.x
Development

Successfully merging this pull request may close these issues.

src/python/pants/pantsd/service/store_gc_service_test is flaky
3 participants
@thejcannon @stuhood @WorkerPants