Write adhoc_tool(stdout/stderr="...") relative to workdir, support absolute paths #18814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Given that this is now more frequently writing into subdirs, there should probably be an extra test to make sure that |
|
(nb. Cherry-pick required back to |
|
Done! I've made a few additional changes:
|
chrisjrn
approved these changes
Apr 26, 2023
huonw
added a commit
to huonw/pants
that referenced
this pull request
Apr 26, 2023
…solute paths (pantsbuild#18814) This fixes pantsbuild#18810 by ensuring `adhoc_tool(stdout="...", stderr="...")` are written relative to the working directory, and before the `root_output_directory` filtering happens. This also fixes a second bug I noticed while working on this: if the path is absolute, e.g. `stdout="/out.txt"`, pants crashes: ```panic at 'called `Result::unwrap()` on an `Err` value: "Absolute paths are not allowed: \"/out.txt\""', src/intrinsics.rs:420```. After this PR, they are supported, and taken to start at the build root.
huonw
added a commit
that referenced
this pull request
Apr 27, 2023
…solute paths (Cherry-pick of #18814) (#18839) This fixes #18810 by ensuring `adhoc_tool(stdout="...", stderr="...")` are written relative to the working directory, and before the `root_output_directory` filtering happens. This also fixes a second bug I noticed while working on this: if the path is absolute, e.g. `stdout="/out.txt"`, pants crashes: ```panic at 'called `Result::unwrap()` on an `Err` value: "Absolute paths are not allowed: \"/out.txt\""', src/intrinsics.rs:420```. After this PR, they are supported, and taken to start at the build root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18810 by ensuring
adhoc_tool(stdout="...", stderr="...")are written relative to the working directory, and before theroot_output_directoryfiltering happens.This also fixes a second bug I noticed while working on this: if the path is absolute, e.g.
stdout="/out.txt", pants crashes:panic at 'called `Result::unwrap()` on an `Err` value: "Absolute paths are not allowed: \"/out.txt\""', src/intrinsics.rs:420. After this PR, they are supported, and taken to start at the build root.