Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear FSDB materialization cache when removeing a file #18747

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Clear FSDB materialization cache when removeing a file #18747

merged 4 commits into from
Apr 14, 2023

Conversation

thejcannon
Copy link
Member

Scenario:

  • daemon starts
  • materializes FSDB file, entry added to dest_initializer
  • GC eventually kicks in and calls remove on an FSDB file
  • all_fingerprints doesn't return a fingerprint for the file because it was removed
  • Attempt to store the file, but we re-use the OnceCell entry in dest_initializer, so it's a no-op
  • Hardlinking fails 😢

New test fails before, passes after

I don't think this bug is #18661 though :/

@thejcannon thejcannon added the category:bugfix Bug fixes for released features label Apr 14, 2023
@thejcannon thejcannon requested a review from stuhood April 14, 2023 16:37
@thejcannon thejcannon merged commit 9616025 into pantsbuild:main Apr 14, 2023
@thejcannon thejcannon deleted the fix-FSDB-GC-bug branch April 14, 2023 18:56
@huonw huonw mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejcannon @stuhood