Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A RuleRunner subclass to set ICs in Python-related tests. #18709

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Apr 10, 2023

Subsequent PRs will apply this in relevant tests, so we can remove
one of the hacks introduced in #18627.

I have applied this to several tests and verified that it works.

@benjyw benjyw added the category:internal CI, fixes for not-yet-released features, etc. label Apr 10, 2023
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this a private file? We probably don't want a new API that plugin authors come to depend on and now we have to deprecate.

@benjyw
Copy link
Contributor Author

benjyw commented Apr 10, 2023

Maybe make this a private file? We probably don't want a new API that plugin authors come to depend on and now we have to deprecate.

Well, but this is a useful class for plugin authors. Why would we have to deprecate it?

@Eric-Arellano
Copy link
Contributor

Why would we have to deprecate it?

Yeah I guess the plugin API still lets us delete things without deprecation

Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Done exactly as what I had in mind 😎

@kaos
Copy link
Member

kaos commented Apr 10, 2023

Why would we have to deprecate it?

Yeah I guess the plugin API still lets us delete things without deprecation

Eric, I think you got the question backwards. At least I think it was "why would we want to delete it?"

@benjyw
Copy link
Contributor Author

benjyw commented Apr 10, 2023

Why would we have to deprecate it?

Yeah I guess the plugin API still lets us delete things without deprecation

I mean why would we delete it? It's pretty useful.

@benjyw
Copy link
Contributor Author

benjyw commented Apr 10, 2023

To clarify, this isn't a temporary thing. At least, I don't expect it to be.

@Eric-Arellano
Copy link
Contributor

Ah, I thought this was meant to be temporary while you fix individual tests. Sg.

@benjyw
Copy link
Contributor Author

benjyw commented Apr 10, 2023

Ah, no, this is the fix. Seemed better than repeating a fiddly option set up in dozens of places.

@benjyw benjyw merged commit 72a08df into pantsbuild:main Apr 10, 2023
@benjyw benjyw deleted the python_rule_runner branch April 10, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants