-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A RuleRunner subclass to set ICs in Python-related tests. #18709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this a private file? We probably don't want a new API that plugin authors come to depend on and now we have to deprecate.
Well, but this is a useful class for plugin authors. Why would we have to deprecate it? |
Yeah I guess the plugin API still lets us delete things without deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Done exactly as what I had in mind 😎
Eric, I think you got the question backwards. At least I think it was "why would we want to delete it?" |
I mean why would we delete it? It's pretty useful. |
To clarify, this isn't a temporary thing. At least, I don't expect it to be. |
Ah, I thought this was meant to be temporary while you fix individual tests. Sg. |
Ah, no, this is the fix. Seemed better than repeating a fiddly option set up in dozens of places. |
Subsequent PRs will apply this in relevant tests, so we can remove
one of the hacks introduced in #18627.
I have applied this to several tests and verified that it works.