Improve debug information for docker auth, and expose an environment variable. #18599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Mar 27, 2023
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 27, 2023
…variable. (pantsbuild#18599) Improve debug information for docker auth, and expose one additional fundamental environment variable. Although we could potentially create an option to allow for exposing additional environment variables to `pantsd`, the ones which have been required so far are fundamental, and don't imply the need for an option. Time will tell though.
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 27, 2023
…variable. (pantsbuild#18599) Improve debug information for docker auth, and expose one additional fundamental environment variable. Although we could potentially create an option to allow for exposing additional environment variables to `pantsd`, the ones which have been required so far are fundamental, and don't imply the need for an option. Time will tell though.
stuhood
added a commit
that referenced
this pull request
Mar 28, 2023
…variable. (Cherry-pick of #18599) (#18604) Improve debug information for docker auth, and expose one additional fundamental environment variable. Although we could potentially create an option to allow for exposing additional environment variables to `pantsd`, the ones which have been required so far are fundamental, and don't imply the need for an option. Time will tell though.
stuhood
added a commit
that referenced
this pull request
Mar 28, 2023
…variable. (Cherry-pick of #18599) (#18603) Improve debug information for docker auth, and expose one additional fundamental environment variable. Although we could potentially create an option to allow for exposing additional environment variables to `pantsd`, the ones which have been required so far are fundamental, and don't imply the need for an option. Time will tell though.
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve debug information for docker auth, and expose one additional fundamental environment variable.
Although we could potentially create an option to allow for exposing additional environment variables to
pantsd, the ones which have been required so far are fundamental, and don't imply the need for an option. Time will tell though.