Set the entire env in __run.sh #18582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens e.g., in lint/fmt, where we don't pass env vars.
|
Please double-check my Rust, as I am just fumbling along there still. |
jsirois
approved these changes
Mar 24, 2023
export line in __run.sh.
jsirois
approved these changes
Mar 24, 2023
| cd {stringified_cwd} | ||
| {stringified_command_line} | ||
| env -i {stringified_env_vars} {stringified_command_line} |
There was a problem hiding this comment.
I've done this by hand myself reproing user issues and it worked fine. Did you double check this still works?
There was a problem hiding this comment.
Yep, ran a few different command (test, lint, fmt) with --keep-sandboxes=always, cd'd into the sandbox and ran __run.sh to ensure that the process still does the thing we expect it to do.
There was a problem hiding this comment.
I just checked env -i bash -c 'echo $HOME.' -> ".", but I did not gut check a sandbox __run.sh using this change.
This was referenced Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set the explicit env vars passed to the Process on top of the existing env.
Now we use
env -ito force the process to run with exactly the same env as it didin the engine. This will create a much more faithful debugging setup when you poke
around in the sandbox and run
__run.sh.