Disable hardlinking of immutable inputs (Cherry-pick of #18487) #18492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As determined in pantsbuild#18162, hardlinking unfortunately does not play well with any of the implementations of Docker for macOS's filesystem virtualization. This change re-disables hardlinking of immutable inputs until pantsbuild#18162 and/or pantsbuild#18153 (which currently plans to switch to using symlinks for large files) are resolved.
|
@thejcannon : I think that independent of #18501, your instinct to avoid shipping the automatic hardlinking of inputs as immutable until #18153 has landed is probably good, so I think that we should land this for |
|
Completely agree 💯 |
Just need a shipit then please! |
thejcannon
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As determined in #18162, hardlinking unfortunately does not play well with any of the implementations of Docker for macOS's filesystem virtualization.
This change re-disables hardlinking of immutable inputs until #18162 and/or #18153 (which currently plans to switch to using symlinks for large files) are resolved.