Finish parallelizing materialization of Process inputs #18469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was previously landed as part of #18225 (which was reverted): now broken out independently. |
jsirois
approved these changes
Mar 11, 2023
| @@ -709,89 +735,44 @@ pub async fn prepare_workdir( | |||
| if let Some(working_directory) = &req.working_directory { | |||
| executable_path = working_directory.as_ref().join(executable_path) | |||
| } | |||
| Some(executable_path) | |||
| Some(workdir_path.join(executable_path)) | |||
There was a problem hiding this comment.
Was this a bug-fix picked up along the way? Afaict this is new over and above the shuffle on the LHS.
There was a problem hiding this comment.
Not a bug fix: we have a good test for this. I just pushed up the joining of the workdir_path to avoid an unnecessary clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, the:
... have been created synchronously in
prepare_workdirbefore the call tomaterialize_directoryfor the input digest.As described in the TODO on
prepare_workdir, that prevented validation of collisions between those paths, and also meant that it was less parallel than it could be.This change switches to using the new symlinks-in-
Digests support that @thejcannon added to create aDigestthat fully describes the sandbox, and then materialize that.