Make JVM sources runnable #17847
Merged
Make JVM sources runnable #17847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d2a66b to
3d7f431
Compare
added 6 commits
December 20, 2022 13:51
3d7f431 to
471e138
Compare
|
I've rebased this one extensively. Reviewing the commits individually will yield better results than reading the final diff.. |
chrisjrn
commented
Dec 20, 2022
| @@ -330,9 +372,9 @@ class JunitTestExtraEnvVarsField(TestExtraEnvVarsField): | |||
| # ----------------------------------------------------------------------------------------------- | |||
|
|
|||
|
|
|||
| class JvmMainClassNameField(StringField): | |||
| alias = "main" | |||
| class JvmRequiredMainClassNameField(JvmMainClassNameField): | |||
There was a problem hiding this comment.
I've made this a subclass rather than a standalone class to reduce churn elsewhere in the codebase.
My instinct is that I could make the new _find_main_by_javap helper into a fully-fledged rule, and we could use that when constructing deploy_jars if main is not specified. When that happens, this subclass can just go away.
benjyw
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
./pants run/experimental_run_in_sandboxsupport for more JVM targets without needing to explicitly declare adeploy_jar. It does that by adapting the existingjvm_artifactrule, which was already fairly generic thanks to the use ofClasspathEntryRequestrules.The rules will attempt to automatically find a
mainmethod through either a JAR manifest (as before forjvm_artifact) or by directly inspecting the contents of the classpath entry JAR returned from compilation. This also permits explicitly declaring amainmethod in case the other approaches are inconclusive.