-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a batched local lookup for missing fingerprints. #16627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure of the new `get_missing_fingerprints` function is based on the existing `store_bytes_batch`. [ci skip-build-wheels]
danxmoran
commented
Aug 24, 2022
danxmoran
commented
Aug 24, 2022
[ci skip-build-wheels]
stuhood
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 30, 2022
…d#16627) Closes pantsbuild#16400 The structure of the new `exists_batch` function is based on the existing `store_bytes_batch`. [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…d#16627) Closes pantsbuild#16400 The structure of the new `exists_batch` function is based on the existing `store_bytes_batch`. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16400
The structure of the new
exists_batch
function is based on the existingstore_bytes_batch
.[ci skip-build-wheels]