Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a batched local lookup for missing fingerprints. #16627

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Aug 24, 2022

Closes #16400

The structure of the new exists_batch function is based on the existing store_bytes_batch.

[ci skip-build-wheels]

The structure of the new `get_missing_fingerprints` function is based on
the existing `store_bytes_batch`.

[ci skip-build-wheels]
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@stuhood stuhood merged commit f13409a into pantsbuild:main Aug 24, 2022
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Aug 30, 2022
…d#16627)

Closes pantsbuild#16400

The structure of the new `exists_batch` function is based on the existing `store_bytes_batch`.

[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this pull request Aug 30, 2022
…ck of #16627) (#16701)

Closes #16400

The structure of the new `exists_batch` function is based on the existing `store_bytes_batch`.

[ci skip-build-wheels]
cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022
…d#16627)

Closes pantsbuild#16400

The structure of the new `exists_batch` function is based on the existing `store_bytes_batch`.

[ci skip-build-wheels]
@danxmoran danxmoran deleted the danmoran/batch-exists branch October 4, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a batched local exists call
3 participants