[internal] Leverage PyO3 type conversions #13618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Thank you again @mejrs and @davidhewitt, this type of change is awesome! |
tdyas
approved these changes
Nov 15, 2021
Eric-Arellano
commented
Nov 15, 2021
| @@ -110,7 +110,7 @@ def capture_snapshots( | |||
| scheduler: PyScheduler, | |||
| session: PySession, | |||
| path_globs_and_root_tuple_wrapper: _PathGlobsAndRootCollection, | |||
| ) -> tuple[PySnapshot, ...]: ... | |||
| ) -> list[PySnapshot]: ... | |||
There was a problem hiding this comment.
Given that PyO3 returns Vec<>, I figured we can lean into it - not worth the eager type conversion to tuple.
| .0 | ||
| .core | ||
| .executor | ||
| .enter(|| py.allow_threads(|| py_scheduler.0.metrics(&py_session.0))) |
There was a problem hiding this comment.
The allow_threads is new.
| .workunit_store() | ||
| .encode_observations() | ||
| .map_err(PyException::new_err)?; | ||
| let observations = py.allow_threads(|| { |
There was a problem hiding this comment.
allow_threads is new
| core | ||
| .executor | ||
| .block_on(future::try_join_all(snapshot_futures)) | ||
| let snapshot_futures = path_globs_and_roots |
There was a problem hiding this comment.
This was moved into allow_threads. Same with processing the result
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Nov 15, 2021
This reverts commit 3c9a7ff. [ci skip-build-wheels]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can let PyO3 write the type conversion code for us, as explained in https://pyo3.rs/v0.15.0/conversions/tables.html. This makes our code simpler to read and also allows us to use
py.allow_threads(||)in more places.