Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] add failing test for FrozenDict equality issue #13389

Merged
merged 1 commit into from
Dec 4, 2021
Merged

[internal] add failing test for FrozenDict equality issue #13389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/python/pants/util/frozendict_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ def test_eq() -> None:
assert fd1 != d1


@pytest.mark.xfail(reason="FrozenDict equality broken for different insertion orders.")
def test_eq_different_orders() -> None:
fd1 = FrozenDict({"a": 0, "b": 1})
fd2 = FrozenDict({"b": 1, "a": 0})
assert fd1 == fd2


def test_lt() -> None:
d = {"a": 0, "b": 1}
assert FrozenDict(d) < FrozenDict({"a": 1, "b": 2})
Expand Down