Docker image version tag #13097
Docker image version tag #13097
Conversation
…ions. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
| ) | ||
| except (KeyError, ValueError) as e: | ||
| msg = ( | ||
| "Invalid format string for the `docker_image(version)` field: " |
There was a problem hiding this comment.
People might not know what you mean by "docker_image(version) field". I'd go with "for the version field of the docker_image target at {self.address.spec}`
There was a problem hiding this comment.
I don't have the address at that point, it is added further up the call stack. So the message becomes something like
"Error in {address}: Invalid format string for the version field of the docker_image target."
OK? Otherwise I can pass the address to image_names() for the sake of the error message..
There was a problem hiding this comment.
DockerBuildError: Error in testprojects/src/python/docker:test-example: Invalid format string for the `version` field of the docker_image target: '1.2.5-{typo}'.
The key 'typo' is unknown. Try with one of: baseimage, stage0.
There was a problem hiding this comment.
Doh. Dummy, of course I have the address... 🤦🏽
That is likely most useful only when mirroring images from one registry to another.. but then it helps avoiding typos! :D Plan is to add support for fishing out the |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
In order to keep the BUILD files DRY, support picking up the Docker image version to be built, from other sources rather than require a hard coded value in the BUILD file.
First up is support for looking at the
DockerfileFROM commands to glean possible version tags from them.Example:
FROM upstream:1.2-feat ...This would then produce
myimage:1.2-feat.As more format strings are introduced, so is the potential for users to shot them selves in the foot. So I've added some improved error feedback in case the version or image name template format strings blow up, that should help pinpoint the mistake and present possible solutions.