Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyenv backend does not respect patch version constraints #20175

Closed
engnatha opened this issue Nov 13, 2023 · 1 comment · Fixed by #21139
Closed

pyenv backend does not respect patch version constraints #20175

engnatha opened this issue Nov 13, 2023 · 1 comment · Fixed by #21139
Labels
backend: Python Python backend-related issues bug

Comments

@engnatha
Copy link

Describe the bug
When using the hermetic python install tooling, the python provided does not respect patch version constraints.

One can place interpreter_constraints = ["CPython>=3.8,<=3.8.10"] in pants.toml, but the installed version will pick the latest of 3.8 which is 3.8.16.
Pants version
2.18.0

OS
Ubuntu 20.04

Additional info
I believe this is due to the use of minimum_python_version returning the {major}.{minor} result instead of a complete picture.
@engnatha engnatha added the bug label Nov 13, 2023
@engnatha
Copy link
Author

#19462 (comment) may be relevant

@huonw huonw added the backend: Python Python backend-related issues label Nov 13, 2023
jonasrauber pushed a commit to jonasrauber/pants that referenced this issue Jul 7, 2024
make pyenv backend respect patch version constraints
d7b6137 
fixes pantsbuild#20175

fix inspired by pantsbuild#19462
@jonasrauber jonasrauber mentioned this issue Jul 7, 2024
Merged
@huonw huonw closed this as completed in 1a65ae2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Python Python backend-related issues bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make pyenv backend respect patch version constraints jonasrauber/pants
2 participants
@huonw @engnatha