Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go should look for a minimum required version, not exact version #15204

Closed
Eric-Arellano opened this issue Apr 21, 2022 · 0 comments · Fixed by #15306
Closed

Go should look for a minimum required version, not exact version #15204

Eric-Arellano opened this issue Apr 21, 2022 · 0 comments · Fixed by #15306
Assignees
@Eric-Arellano
Labels
backend: Go Go backend-related issues

Comments

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Apr 21, 2022 •
edited
Loading

Go is very intentional about backwards compatibility. Go 1.18 can build 1.16 for example.

Pants is being overly strict with [golang].expected_version. We currently require an exact match. That makes it harder to get a project building on multiple machines, such as how macOS and home brew use the newest version of go.

The better fix is for pants to install go for you, which is blocked by #13899. In the meantime, this is a good change.
@Eric-Arellano Eric-Arellano added the backend: Go Go backend-related issues label Apr 21, 2022
@Eric-Arellano Eric-Arellano self-assigned this May 2, 2022
@Eric-Arellano Eric-Arellano mentioned this issue May 2, 2022
Merged
Eric-Arellano added a commit that referenced this issue May 3, 2022
@Eric-Arellano
Deprecate [golang].expected_version in favor of more flexible `[gol…
cf17208 
…ang].minimum_expected_version` (#15306)

Closes #15204.

This is much more flexible. If your project uses 1.17, you can still use 1.18. That works because Go's backwards compatibility.

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-Arellano Eric-Arellano

Labels
backend: Go Go backend-related issues
Projects
None yet
Milestone
No milestone
1 participant
@Eric-Arellano