Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--layout=packed should always be used for the repository.pex #13398

Closed
stuhood opened this issue Oct 28, 2021 · 0 comments · Fixed by #13400
Closed

--layout=packed should always be used for the repository.pex #13398

stuhood opened this issue Oct 28, 2021 · 0 comments · Fixed by #13400
Assignees
@stuhood
Labels
bug
Milestone
2.7.x

Comments

@stuhood
Copy link
Member

stuhood commented Oct 28, 2021 •
edited
Loading

Describe the bug
When building a pex_binary when requirements_constraints is set, the repository.pex that is built for the binary will not set --layout=packed, because the request that is triggering the constraints build is not internal_only.

But it should use --layout=packed, since it is only the source of the artifacts for the pex, rather than the exposed artifact. All cases of repository.pex builds should (since they are never exposed verbatim, and always consumed by other builds.)

Pants version
2.7.1
@stuhood stuhood added the bug label Oct 28, 2021
@stuhood stuhood self-assigned this Oct 28, 2021
@stuhood stuhood added this to the 2.7.x milestone Oct 28, 2021
@stuhood stuhood mentioned this issue Oct 28, 2021
Merged
stuhood added a commit that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (#13400)
5fcdd8a 
As described in #13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments. 

Fixes #13398.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (pantsbuild#13400)
60605fb 
As described in pantsbuild#13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments.

Fixes pantsbuild#13398.

[ci skip-rust]
[ci skip-build-wheels]
@stuhood stuhood mentioned this issue Oct 28, 2021
Merged
stuhood added a commit to stuhood/pants that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (pantsbuild#13400)
e88b8f9 
As described in pantsbuild#13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments.

Fixes pantsbuild#13398.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (pantsbuild#13400)
368053b 
As described in pantsbuild#13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments. 

Fixes pantsbuild#13398.

[ci skip-rust]
[ci skip-build-wheels]
@stuhood stuhood mentioned this issue Oct 28, 2021
Merged
stuhood added a commit that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (cherrypick of #13400
59ddfc3 
) (#13402)

As described in #13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments.

Fixes #13398.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this issue Oct 28, 2021
@stuhood
Use --layout=packed for all monolithic resolves. (cherrypick of #13400
1179b6b 
) (#13403)

As described in #13398, we should use `--layout=packed` for all monolithic resolves (lockfiles, all_constraints, etc), in addition to for `internal_only` resolves.

Note that this is _not_ sufficient to allow for cache reuse across internal PEXes (i.e. those created for tests) and external PEXes (`pex_binary`), because the `repository.pex` is constructed with other differing arguments. 

Fixes #13398.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Apr 6, 2022
@stuhood
WIP: Pausing to move pantsbuild#13398 handling into the caller.
51a78e0 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Apr 6, 2022
@stuhood
WIP: Pausing to move pantsbuild#13398 handling into the caller.
6e8589d 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
bug
Projects
None yet
Milestone
2.7.x
Development

Successfully merging a pull request may close this issue.

Use --layout=packed for all monolithic resolves stuhood/pants
1 participant
@stuhood